espressomd / espresso

The ESPResSo package
https://espressomd.org
GNU General Public License v3.0
226 stars 183 forks source link

Issue tracker for Tutorial 04 #3940

Closed jngrad closed 2 years ago

jngrad commented 4 years ago
fweik commented 4 years ago

I'm not sure that introducing Green-Kubo and MSD for the diffusion at once is a good idea. It's too much at once, and a source of confusion, also it did not become clear when you would use what, for the given parameter sets they both work equally well. I think that would still be the case if the polymer part would be factored out as proposed in #3939.

jngrad commented 4 years ago

Regarding performance for large box sizes: boost::iterators::detail::iterator_facade_base<ParticleIterator<Cell**>> accounts for 70% of the total runtime according to valgrind. It's called when iterating over ParticleRanges or local_cells. Increasing the skin by a factor 10 (the same factor as the box size) reduces the iterator footprint to 50% of the total runtime.

With the small box size, the iterator only accounts for 2% of the total runtime.