Rewrite ParticleForce operator+ to improve performance.

espressomd / espresso

The ESPResSo package

https://espressomd.org

GNU General Public License v3.0

226 stars 183 forks source link

Closed RiccardoFrenner closed 2 months ago

RiccardoFrenner commented 2 months ago

Description of changes:

Reduce potential copies made in operator+ of the ParticleForce struct by using operator+= to implement operator+ instead of the other way around.
More information about the performance impact of this are here: https://github.com/espressomd/espresso/issues/4866.

jngrad commented 2 months ago

@RudolfWeeber would you like to review it? It's blocked by a failing lb_lees_edwards_particle_coupling.py test, and I don't understand why: https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/jobs/368189

RudolfWeeber commented 2 months ago

Confirmed that the LE issue is unrelated. Looking into it now.