search

espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
491 stars 1.15k forks source link

app settings in main settings #261

Closed ps-igel closed 4 years ago

ps-igel commented 4 years ago

I think there is still an issue with using the myapp.settings.js to be added to the main settings page (see this change)

I uploaded my own app using the myapp.settings.js file and the menu in it. But it does not show up in the settings. Right now I only see GadgetBridge in there.

One thing I noticed is, that gbridge.info file contains "settings":"gbridge.settings.js" whereas myapp.info does not contain any settings key-value-pair. But this seems to be the filter on which the settings app filters the apps.

The info file is auto-generated from apps.json right? Does it generate the settings key for widgets only and not for apps?

gfwilliams commented 4 years ago

Do you have a link to your code?

myapp.info is automatically generated. In the code you linked you can see the line where it's added: https://github.com/espruino/BangleApps/commit/39621bfae0c659e354840b31ff092e51ab6dca26?diff=unified#diff-7564f118a462298ffcfe7959d3e8875cR64

It should create the pair regardless. Is it possible you've forked BangleApps but haven't updated it to the most recent version, which would have this in?

ps-igel commented 4 years ago

Is it possible you've forked BangleApps but haven't updated it to the most recent version, which would have this in?

I'm an *****. Most likely yes.