search

espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
498 stars 1.17k forks source link

chargent: fix manual/tap hiding of notification #3386

Closed bobrippling closed 7 months ago

bobrippling commented 7 months ago

Introduced by and documented in #3262.

This also shortens the message length to fit on the screen

bobrippling commented 7 months ago

@thyttan does this fix that notification problem?

thyttan commented 7 months ago

does this fix that notification problem?

I tried this the other day and no, not for my setup as it seemed... 🤷‍♂️

bobrippling commented 7 months ago

Interesting - it fixes the exception from clearInterval(undefined) which was causing the problem for me. Do you still see the notification bar staying at the top permanently? Is there any IDE output?

thyttan commented 7 months ago

I'm sorry - much of this has probably been user error on my part :)

After reading the readme more carefully I see it's supposed to warn when battery indication in UI said 100 % for a few minutes. I mistakenly believed it should have buzzed at UI indication 80 %.

thyttan commented 7 months ago

Thanks!

bobrippling commented 7 months ago

Ah no worries! Thanks for helping test it out - wouldn't have found the fix without you :)