search

espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
498 stars 1.17k forks source link

Implements more asserts and reading testcases from json files #3399

Closed halemmerich closed 6 months ago

halemmerich commented 7 months ago

This is mostly a base for discussion in https://forum.espruino.com/conversations/395324/ and extends the runapptests.js by @gfwilliams .

halemmerich commented 6 months ago

I think this is now ok to merge. It is only missing a merged https://github.com/espruino/EspruinoAppLoaderCore/pull/61 and the update of core to pull the change into this repo.

bobrippling commented 6 months ago

Thanks - I've merged #3410 which brings in those app loader core changes. Will leave to @gfwilliams to approve with this being a reasonably central change.

Unrelated / for another time, but I wonder whether we attempt to run the app tests as part of CI, wdyt?

gfwilliams commented 6 months ago

This looks great - thanks for your work on it!

halemmerich commented 6 months ago

Unrelated / for another time, but I wonder whether we attempt to run the app tests as part of CI, wdyt?

I think that would be great. Don't know if we would hit some github limits when we get to a substantial amount of tests, but generally that should be a good idea.

gfwilliams commented 6 months ago

Yes, I think at some point it'd be great to enable these. At least when it's just a few apps it's not going to be a huge amount of extra CPU use.