search

espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
498 stars 1.17k forks source link

smclock - Updated backgrounds #3409

Closed smekras closed 2 months ago

smekras commented 6 months ago

Been a while since i made one of those. only changed stuff in my app.

thyttan commented 6 months ago

The new linter rules picked up:

Check warning on line 29 in apps/smclock/app.js GitHub Actions / build

'showAnalogFace' is assigned a value but never used

Could you remove that variable or comment it out please.

Just looking at the code I think it looks good otherwise.

thyttan commented 6 months ago

Just installed from your personal app loader with weird result (cutting edge firmware): image

Trying the previous version (0.07) seems to work as expected: image

thyttan commented 5 months ago

When using the default 3bit mode I get this error:

 ____                 _
|  __|___ ___ ___ _ _|_|___ ___
|  __|_ -| . |  _| | | |   | . |
|____|___|  _|_| |___|_|_|_|___|
         |_| espruino.com
 2v22.15 (c) 2024 G.Williams
Uncaught Error: Palette specified, but must be a flat Uint16Array of 2,4,8,16,256 elements
 at line 20 col 1422 in smclock.app.js
...ork;}g.drawImage(background);batColor=getBatteryColor(batLev...
                              ^
in function "draw" called from line 20 col 2908 in smclock.app.js
...clear();pollBattery();draw();var batInterval=setInterval(pollBa...
                                 ^
>

4bit works as well as "work".

thyttan commented 2 months ago

@smekras feel free to open this again if you want to. Closing for now.