search

espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
478 stars 1.14k forks source link

[runplus] Having both Run and Run+ is confusing #3437

Closed pavelmachek closed 3 months ago

pavelmachek commented 3 months ago

Affected hardware version

Bangle 2

Your firmware version

2vXX

The bug

Could we merge functionality of Run and Run+, or perhaps just drop Run as Run+ is a superset? Having both is confusing, and it let me to debugging "why does not zooming in work for me". Well.. it did not as I had Run and feature is only available in Run+.

Installed apps

No response

thyttan commented 3 months ago

The reason runplus is not just in run is for Bangle.js 1 to be able to run it within RAM constraints. So they will not be merged (edit: maybe e.g. the zoom functionality would fit in run - don't know) or removed 🙂

Why did you get them mixed up? Maybe wording in readme could be clearer? Maybe runplus should have an altered icon? Suggestions and PRs welcome as always 😃

thyttan commented 3 months ago

I guess we could remove the Bangle.js 2 from compatible devices in run's metadata. But I don't know if I'd prefer that.

bobrippling commented 3 months ago

Related: #2847 and this commit comment thread

I think dropping Bangle 2 from run and Bangle 1 from runplus would solve the majority of the issue though

halemmerich commented 3 months ago

I think we should keep the supports tag in metadata strictly for ability to work on the device. If we start deciding that on subjective factors we are going to have problems down the line. run is actually a nice example as runplus might deviate from the feature set further in the future. Having run available on Bangle 2 is useful, be it as the default app for running or even the lighter on RAM alternative if the user has other priorities and uses memory heavy stuff alongside run.

bobrippling commented 3 months ago

Perhaps a suggested upgrade - if the user's selected BangleJS 2 as their device, we could have a metadata field which references the upgraded app, and we show that as a hint in the app loader

thyttan commented 3 months ago

Why did you get them mixed up? Maybe wording in readme could be clearer? Maybe runplus should have an altered icon? Suggestions and PRs welcome as always 😃

@pavelmachek did you have some feedback regarding this?

pavelmachek commented 3 months ago

So what happened was that after various backups/restore cycles I was updating "run" application, wondering why I'm not getting new features from runplus.

pavelmachek commented 3 months ago

I was not aware that run / runplus is due to BangleJS 1 limitations. Perhaps "Not recommended on BangleJS 2, use runplus" note in application description would solve the confusion?

thyttan commented 3 months ago

Added hints in run app README and description: 13e25279b92c5395ce82add263da9459f2970e03 5b785bc5d14ea62f7e74c118daf1336c9dae4a8c

I think that's good enough for now.