search

espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
498 stars 1.17k forks source link

Burn - Simple Calorie Counter #3448

Closed slynchDev closed 5 months ago

slynchDev commented 5 months ago

Fixes applied per your suggestion (prior PR)

slynchDev commented 5 months ago

My apologies, I should have kept the prior PR and updated that branch rather than create a new PR (still learning the process here). I applied your suggestions: remove a few unused variables, removed .prettierignore, renamed all app files per the standard in the repo. Thanks

thyttan commented 5 months ago

Thank you for the app and the quick changes! Always fun to see new contributors! :)

slynchDev commented 5 months ago

Thank you! I did have a couple questions if you don’t mind?

1) I see there a centralized health service to store calories information like this?

2) Any chance you could elaborate on your boot.js feature request (calculate on startup)?

Sean

On Sun, Jun 9, 2024 at 2:52 PM thyttan @.***> wrote:

Thank you for the app and the quick changes! Always fun to see new contributors! :)

— Reply to this email directly, view it on GitHub https://github.com/espruino/BangleApps/pull/3448#issuecomment-2156805289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMDUZ2EW2J2HWO4UDXL3CLZGTFBDAVCNFSM6AAAAABJBFVCWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWHAYDKMRYHE . You are receiving this because you authored the thread.Message ID: @.***>

thyttan commented 5 months ago

Thank you! I did have a couple questions if you don’t mind?

Sure - I'll answer to the best of my abilities. :)

1) I see there a centralized health service to store calories information like this?

There's the health app that log some stats, https://thyttan.github.io/BangleApps/?q=health, is that what you're referencing? @gfwilliams has proposed to add more stats to health here: https://github.com/espruino/BangleApps/issues/3275#issuecomment-2006364430

2) Any chance you could elaborate on your boot.js feature request (calculate on startup)?

The suggestion was based of my misunderstanding of the app. I thought the idea was that it would automatically estimate calories burned based on activity. If that had been the case it would have made sense to have logic running at all times, also when other apps/the clock was running, to keep track on the activity/calorie burn. But as I understand it the idea is you use the app to count caloric intake?

slynchDev commented 5 months ago

Thanks so much. Yes, it’s simply used to count caloric intake.

Ok I will take a closer look at the health app to see if / when there’s an integration opportunity.

Thanks!

On Sun, Jun 9, 2024 at 4:10 PM thyttan @.***> wrote:

Thank you! I did have a couple questions if you don’t mind?

Sure - I'll answer to the best of my abilities. :)

  1. I see there a centralized health service to store calories information like this?

There's the health app that log some stats, https://thyttan.github.io/BangleApps/?q=health, is that what you're referencing? @gfwilliams https://github.com/gfwilliams has proposed to add more stats to health here: #3275 (comment) https://github.com/espruino/BangleApps/issues/3275#issuecomment-2006364430

  1. Any chance you could elaborate on your boot.js feature request (calculate on startup)?

The suggestion was based of my misunderstanding of the app. I thought the idea was that it would automatically estimate calories burned based on activity. If that had been the case it would have made sense to have logic running at all times, also when other apps/the clock was running, to keep track on the activity/calorie burn. But as I understand it the idea is you use the app to count caloric intake?

— Reply to this email directly, view it on GitHub https://github.com/espruino/BangleApps/pull/3448#issuecomment-2156868476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMDUZ37DGCETO6WCHSDIQDZGTOFJAVCNFSM6AAAAABJBFVCWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWHA3DQNBXGY . You are receiving this because you authored the thread.Message ID: @.***>