lcdclock/lcdclockplus: fix special characters in clockinfo menus

espruino / BangleApps

Bangle.js App Loader (and Apps)

https://banglejs.com/apps

MIT License

498 stars 1.17k forks source link

lcdclock/lcdclockplus: fix special characters in clockinfo menus #3592

Closed Freubert closed 2 months ago

Freubert commented 2 months ago

When syncing e.g. weather info on the watch, the display/layout for temperature is broken/misplaced/invisible on lcdclock and lcdclockplus inside the clockinfo menus. screenshot_20240927-105228 screenshot_20240927-105021

This PR fixed that issue by removing special characters from the clockinfo item text that can't be displayed by 7seg font. The width calculation for the size definition becomes more accurate, which leads to a correct placement of the text. screenshot_20240927-102959 screenshot_20240927-103607

kamilkrz commented 2 months ago

This looks like need for version bump to be addressed in updater.

bobrippling commented 2 months ago

Nice find, thanks! And thanks for catching both apps too