espruino / BangleApps

Bangle.js App Loader (and Apps)
https://banglejs.com/apps
MIT License
496 stars 1.17k forks source link

chore: rm semicolons at end of clkinfo + settings #3627

Closed thyttan closed 3 weeks ago

thyttan commented 4 weeks ago

This was done in response to https://github.com/espruino/BangleApps/commit/9185793042c7bfddba13333d33f678c2ca246e5d#commitcomment-148439450 .

thyttan commented 4 weeks ago

Shouldn't need version bumps for most of the apps right?

bobrippling commented 4 weeks ago

Shouldn't need version bumps for most of the apps right?

I suppose it depends if old versions (with semi-colons) will work with the newer code?

thyttan commented 4 weeks ago

Shouldn't need version bumps for most of the apps right?

I suppose it depends if old versions (with semi-colons) will work with the newer code?

Yes - I suppose you're right 😬😅

I'll get a chance to practice vim macros I guess!

bobrippling commented 4 weeks ago

I'll get a chance to practice vim macros I guess!

If it helps, one approach might be:

vim $(
  git diff --numstat origin/master... |
  awk '{print $3}' |
  cut -d/ -f2 |
  uniq |
  sed 's;.*;apps/&/metadata.json;'
) 

Then in vim:

:set hidden<CR>qa/version":<CR>f.<C-A>yi":e %:h/CHA*<CR>:$pu<CR>A: Remove semi-colon from settings & clkinfo<Esc>:n<CR>@aq@a
gfwilliams commented 4 weeks ago

Both versions should work with the either code, so I wouldn't worry about the version bump. I don't think it's going to be a problem either way

gfwilliams commented 3 weeks ago

Looks good to me, thanks! Just merging