search

espruino / Espruino

The Espruino JavaScript interpreter - Official Repo
http://www.espruino.com/
Other
2.79k stars 747 forks source link

Reporting interrupted execution #2163

Open gfwilliams opened 2 years ago

gfwilliams commented 2 years ago

Right now, if execution is interrupted (either Ctrl-C, or out of memory) the position of the interruption is not reported.

In some cases (eg out of memory) doing a stack trace initially may not be possible, however maybe when the execution scope is freed it would be. We could add an INTERRUPTED_REPORTED flag and then:

// at end of function execution...
if (jspIsInterrupted() && !INTERRUPTED_REPORTED) {
  // add stack trace
  INTERRUPTED_REPORTED = true;
}

I think if there's an exception the stack trace is automatically reported, so maybe at end of function execution when we have some more vars free we could actually create an Out of memory exception/similar.

sfemat commented 3 months ago

Any news on this? I'm having lots of execution interrupted with a Puck.js and it's quite hard to debug the cause

gfwilliams commented 3 months ago

Does it give any clue as to why it's interrupted? Maybe check E.getErrorFlags() as that also clears the flags and they get reported in the console again.

It might actually be that the Puck is running out of memory, in which case memory is so low it wouldn't be able to store a stack trace anyway.

sfemat commented 3 months ago

Yes, it's running out of memory and looking at usage over time it seems like a memory leak. Could this be an espruino issue related to the various timers I'm using? I don't see any reasons my code would be causing that.

gfwilliams commented 3 months ago

Are you running up to date firmware? It could be a firmware issue, but it's actually pretty unlikely.

You could try using https://github.com/espruino/EspruinoMemView to track down what the issue is? See the readme there for info - but basically you're looking for either a ton of unconnected items (in which case it could well be a firmware bug) or maybe a big 'star' shape in which case if you can hover the mouse over the line leading to it, it'll probably have the name of the variable that's taking all the memory

sfemat commented 2 months ago

image Here is the mem view for a puck with execution interrupted, does the number of unconnected look unusual?

gfwilliams commented 2 months ago

Yes, that looks like a memory leak somewhere. Please could you hover your mouse over some of those and see if there's any text associated that might help narrow it down? For me to do anything with this I'd really need a copy of your code and a way to reproduce it.

Also, are you definitely on the latest firmware?