espruino / Espruino

The Espruino JavaScript interpreter - Official Repo
http://www.espruino.com/
Other
2.76k stars 741 forks source link

NRF.updateServices() needs fixing for ESP32 #2292

Closed MaBecker closed 4 months ago

MaBecker commented 1 year ago

NRF.setServices({
  0xBCDE : {
    0xABCD : {
      value : "Hello",
      maxLen : 20,
      notify: true
    }
  }
});

NRF.updateServices({
  0xBCDE : {
    0xABCD : {
      value : "World",
      indicate: true
    }
  }
});

/*
FIXME
Uncaught Error: Unable to find service with UUID 0xabcd
 at line 8 col 2
});
 ^

*/
gfwilliams commented 1 year ago

Thanks! I'm not 100% sure if this actually worked before - I don't think it's one of the things I tested.

MaBecker commented 1 year ago

It did not work before

MaBecker commented 1 year ago

see #1730