search

espruino / Espruino

The Espruino JavaScript interpreter - Official Repo
http://www.espruino.com/
Other
2.73k stars 741 forks source link

"STRINGIFY" redefined #2467

Closed brendena closed 4 months ago

brendena commented 4 months ago

So "STRINGIFY" seems to already be named in nordic_common.h

targetlibs/nrf5x_15/components/libraries/util/nordiccommon.h:142: warning: "STRINGIFY" redefined 142 | #define STRINGIFY(val) STRINGIFY(val)

So I'm suggesting just renaming STRINGIFY to STRINGEFY. Then changing the names inside this project. The define shows up around 8 times so it should be easy fix.

Should get the point across but still be unique enough such that the define won't be in any library.

gfwilliams commented 4 months ago

Thanks - yes, it was a minor annoyance but it didn't really affect the build as the defines all did the same thing.

I've just renamed it to ESPR_STRINGIFY - I think generally when we have issues like this we should just prefix with JS or ESPR (ESPR_ is used for a lot of #defines). At least then it's obvious it's related to espruino