search

espruino / Espruino

The Espruino JavaScript interpreter - Official Repo
http://www.espruino.com/
Other
2.73k stars 741 forks source link

Disabling unused warnings #2472

Closed brendena closed 4 months ago

brendena commented 4 months ago

Removing warning is usually a bad thing, but for a project that supports so many devices and pieces of hardware i think these kinds of errors are hard to avoid.

So personally i remove these warnings to make potentially larger more problematic problems easier to see.

But this is just a suggestion.

gfwilliams commented 4 months ago

Sorry, but I'm not a fan of this one I'm afraid - generally I do try and avoid the warnings, and those ones can be helpful.

I know it seems like there are a lot, but actually a lot of effort has gone in to fixing warnings.

We have the NOT_USED macro to help with unused parameters and things like that which tends to be used. While the Emscripten build was a bit of a hack/afterthought on the whole we do try and use NOT_USED to avoid the warnings in most builds.

brendena commented 4 months ago

Disabling warning is usually a bad thing so i understand.

Since you're already dealing with this. I'll follow suit.