search

espruino / Espruino

The Espruino JavaScript interpreter - Official Repo
http://www.espruino.com/
Other
2.73k stars 741 forks source link

fix overlays being cut off from the top #2522

Closed ssievert42 closed 1 week ago

ssievert42 commented 1 week ago

Previously, overlays were always positioned at y=0 and the y pos was cut off from the top part of the buffer.

That behaviour was introduced by: fdbf0bfd2590bf241eabe3877b283a78391035ef Since that commit, the coordinates of a GfxDrawImageLayer were changed to be the position in pixels, multiplied by 256. The overlay y position now has to be multiplied by 256 as well, before assigning it to the y start coordinate of a GfxDrawImageLayer.

Closes #2520 (See that issue for screenshots and some more info.)

gfwilliams commented 1 week ago

Thanks for tracking this down - that's great!