search

espruino / Espruino

The Espruino JavaScript interpreter - Official Repo
http://www.espruino.com/
Other
2.73k stars 741 forks source link

discussion: SetUI Q3 changes #2526

Closed thyttan closed 2 days ago

thyttan commented 3 days ago

@gfwilliams

Related issues: https://github.com/espruino/BangleApps/issues/3435 https://github.com/espruino/BangleApps/pull/3452

I've tweaked setUI for Bangle.js 2 to try and achieve goals discussed previously in the issues linked above, regarding the opinion that hw button edge should be rising - and that setting custom handlers on any mode of setui should be possible.

Here I tweaked spotrem to take advantage of these setUI changes to move all input logic inside setUI: https://github.com/espruino/BangleApps/pull/3485

NOT THOROUGHLY TESTED!

gfwilliams commented 2 days ago

Just to add I think this still needs a lot of testing.

We've gone from in https://github.com/espruino/BangleApps/issues/3435 having an app that enables this for users that want it, to enabling it for everyone.

Personally I'd quite like to see this as an app that overrides setUI and then let users install it and get some feedback before we put this in for good, because right now I think the only other person to look at it is @bobrippling?

thyttan commented 2 days ago

@gfwilliams thanks! I'll refactor to the callback solution and package it as an app.