search

espruino / EspruinoDocs

See http://espruino.com for the complete Espruino Documentation - many links in this repository will not work
http://www.espruino.com/
Other
260 stars 284 forks source link

Remove duplicate meridian #738

Closed ruvilonix closed 1 month ago

ruvilonix commented 1 month ago

Meridian is already included in time(), so calling meridian() makes the string have two meridians.

gfwilliams commented 1 month ago

Thanks! Sorry about this.

It looks like the 'default' locale contains meridian (https://github.com/espruino/Espruino/blob/master/libs/js/banglejs/locale.js) but none of the other locales you might install with the Languages app do. @atjn

I've just pushed a change to the main Bangle.js firmware so that on a cutting edge firmware (or 2v25 when released) the meridian will be removed from the built-in locale so it matches what happens elsewhere.

So for now if developing with a clock I'd do what we mention in the tutorial and just install the Languages app (and soon the 2v25 firmware will come out and will fix this by default).

atjn commented 1 month ago

I must have made a mistake when testing this. Sorry about that :)