espruino / EspruinoWebIDE

The Espruino Web IDE - A Chrome Web App for programming Espruino
Apache License 2.0
366 stars 158 forks source link

Bugs: Tabs overlap buttons in top right corner #301

Open thyttan opened 3 days ago

thyttan commented 3 days ago

The bugs

Screenshot from 2024-09-29 17-47-36 In this picture we see that the file tabs draw over the buttons in the corner. The user is still able to interact with the buttons.

Screenshot from 2024-09-29 17-48-11 In this picture we see the tabs wrap to fit on screen. Now the buttons are no longer interactable with the mouse.

The pictures above show two bugs - overlap of tabs and buttons; buttons becoming unavailable to the user when the tab bar wraps (resolved by closing tabs untill it doesn't wrap anymore).

The bugs are not new. I think I've seen them since the tabs were introduced. Since they aren't too problematic I didn't report them before.

Some potential solutions or mitigating changes:

My system

OS: Fedora Linux 40 (Workstation Edition) Browser: Chromium Version 129.0.6668.58 (Official Build) Fedora Project (64-bit)

gfwilliams commented 3 days ago

Thanks - yes, it's been an issue with tab overlap since tabs were introduced.

Scrolling seems like it could be a neat solution, and hopefully can just be CSS - although as you say pushing it to the left first would be neat.

One thing that might be handy is right now the tabs are hard-coded to start at 50%, but really the start point should be set to the position of the splitter in the middle.

If anyone wants to contribute a PR that'd be great!