espruino / winnus

Windows 8.1 and above BLE NUS support for Node.js
3 stars 5 forks source link

Documentation and examples of winnus #3

Closed OwenBrotherwood closed 7 years ago

OwenBrotherwood commented 7 years ago

https://github.com/OwenBrotherwood/winnus/tree/docExample


This is my suggestion as to how to indicate a work in progress where the work is done on my own branch and a clear indication in the issue that the branch is ready if acceptable rather than a pull request and ensuing spam. No comment needed if ok.

gfwilliams commented 7 years ago

Looks great - thanks! Just pulled.

In future, if instead of the 'Ok to pull' commit, you just issue a pull request from a branch when ready, I can merge it easily.

It's just when you issue a pull request and continue to commit to it, I have no idea if I should be merging it or not.