Don't show a gray screen forever if the server doesn't accept the connection

espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release

Mozilla Public License 2.0

127 stars 24 forks source link

Don't show a gray screen forever if the server doesn't accept the connection #177

Closed cpsdqs closed 7 years ago

cpsdqs commented 7 years ago

Currently, it'll just show this and reload the page every few seconds screenshot

cpsdqs commented 7 years ago

In conjunction with this, it may be good to have a better indicator for “you've been disconnected” than the flickering gif in the top-right corner which goes off-screen when you scroll

MightyPork commented 7 years ago

Yeah some overlay with "Reconnecting(flashing dots)" would be nice The whole reconnect thing is a little rough atm,I think one of the timers sometimes fires when it should be stopped and reloads it when it's no longer needed

On Sep 15, 2017 11:54 AM, "cpsdqs" notifications@github.com wrote:

In conjunction with this, it may be good to have a better indicator for “you've been disconnected” than the flickering gif in the top-right corner which goes off-screen when you scroll

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/espterm/espterm-firmware/issues/177#issuecomment-329737361, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8lHgueeJmkA48wRvgIo5HdiC7VDBCMks5siklqgaJpZM4PYvsD .

cpsdqs commented 7 years ago

I added this screen showing disconnected

MightyPork commented 7 years ago

is it in git? I still have the old behavior when the esp restarts

cpsdqs commented 7 years ago

it is now

MightyPork commented 7 years ago

what a mess xD it works, with some glitches:

the regular ajax spinner is still popping up with each request
it flashes for like 2 segments and then hides again during the heartbeat polling

cpsdqs commented 7 years ago

well the code for setting the status screen is in term.js:9–14, change it all you want

cpsdqs commented 7 years ago

So about something related to this issue; why exactly does it reload when the ping is successful?

MightyPork commented 7 years ago

i think it's from back when the initial data load was done via ajax and not by sending i to the WS. now naturally the better solution would be to just re-open the socket

MightyPork commented 7 years ago

reloading the page also re-loads the window title that's atm not sent back with the initial load (i). but that not happening is a minor drawback