search

espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release
Mozilla Public License 2.0
127 stars 24 forks source link

No way to copy text without a CMD button #179

Closed MightyPork closed 7 years ago

MightyPork commented 7 years ago

context menu is good for nothing and ctrl-c is consumed by the input handler (if it would do anything anyway)

screenshot_20170915_221112

MightyPork commented 7 years ago

at least I think you can copy on mac. certainly not on linux

cpsdqs commented 7 years ago

I thought I added ⌃⇧C? But I could add a hack that'd make the text available for the context menu

MightyPork commented 7 years ago

ah yes cs-c works. we need to document that a hack for the context menu would be nice (but it's also kinda cool you can save the image?!)

cpsdqs commented 7 years ago

here's a proof of concept for the hack https://codepen.io/cpsdqs/pen/eGNogw?editors=0010 it's really hacky.

MightyPork commented 7 years ago

whoa that's some serious clickjacking. let's maybe not

On Fri, Sep 15, 2017 at 11:15 PM, cpsdqs notifications@github.com wrote:

here's a proof of concept for the hack https://codepen.io/cpsdqs/pen/ eGNogw?editors=0010 it's really hacky.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/espterm/espterm-firmware/issues/179#issuecomment-329905417, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8lHq5SMfvzPcPdxuRCnwOKkWYFG9e-ks5siukHgaJpZM4PZdR3 .

cpsdqs commented 7 years ago

Yeah we could also just use a custom context menu (could keep the “save image”)

MightyPork commented 7 years ago

if there can be both that's a big win imo- but [low prio]