search

espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release
Mozilla Public License 2.0
127 stars 24 forks source link

Split the monstrous screen class to smaller units #183

Closed MightyPork closed 7 years ago

MightyPork commented 7 years ago

but I'm not sure how ...

for start maybe we can at least have stuff like notification showing, beeping and setting labels elsewhere (ie. the entire thing that branches by the first letter of the update object)

cpsdqs commented 7 years ago

well it would certainly be nice if there were a way to not have to put everything external into global scope

(ES2015 modules is still not well supported. Also, it would probably overload the server)

MightyPork commented 7 years ago

It goes through babel already, so if you think that's a way to make it cleaner...

MightyPork commented 7 years ago

or well that webpack thing. if the overhead is not too big

cpsdqs commented 7 years ago

about 2kb minus babel? (I didn't check how much webpack itself was)

MightyPork commented 7 years ago

i'll make an issue for that (bc i like issues :)

MightyPork commented 7 years ago

okay so I've split off themes and the color table for a start (and the themes module is for now in global scope for use by the color previews)

cpsdqs commented 7 years ago

this commit https://github.com/espterm/espterm-front-end/commit/9ccf9dd2cf1920fd143e199476efbd667175ac94

note that I might have inadvertently broken some things

MightyPork commented 7 years ago

that's a big one

i'll try to test it asap