espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release
Mozilla Public License 2.0
127 stars 24 forks source link

Selecting is messed up #193

Closed MightyPork closed 7 years ago

MightyPork commented 7 years ago

idk what exactly happened there yet, probably some logic that assumes fg and bg hold the current color but they can be 0,0 when bits 8 and 9 (HAS_FG, HAS_BG) are not 1

screenshot_20170924_033021

cpsdqs commented 7 years ago

aaah what happened espterm-emulator is no longer compatible

cpsdqs commented 7 years ago

Fixed—you accidentally made it look up the selection colors in the palette https://github.com/espterm/espterm-front-end/commit/a196f9a9de50010604ad3cbd00e775f1b8f30a7d

MightyPork commented 7 years ago

ah yeah i broke it real good lol but it shan't happen again at this scale, utf8 data fields can stretch to 2.5 bytes