try to use passive event listeners

espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release

Mozilla Public License 2.0

127 stars 24 forks source link

Closed MightyPork closed 7 years ago

MightyPork commented 7 years ago

not sure if this helps anything, but chrome is complaining about those with verbose logging enabled

screenshot_20170924_180728

cpsdqs commented 7 years ago

Can't make wheel passive because passive event listeners can't preventDefault. Also why are we using the non-standard mousewheel?

MightyPork commented 7 years ago

alright, just reporting what i see :p

i'm recycling what i used earlier, so it must be from some old project ...

cpsdqs commented 7 years ago

There's not a lot of event listeners listed in that violation message that can be passive in fact, there's only one https://github.com/espterm/espterm-front-end/commit/16436a9a9886a692803785bfc000ee721d7d7a7b