espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release
Mozilla Public License 2.0
127 stars 24 forks source link

Recolor screen margin #216

Closed cpsdqs closed 7 years ago

cpsdqs commented 7 years ago

Especially noticeable in this screenshot:

screenshot of white background but black screen margin

The screen margin doesn't update its color with the screen backgrounds or themes and can thus kind of break the seamless style.

Possible solutions:

MightyPork commented 7 years ago

idk ... muted adjacent color sounds fun

talking of changing color, there can also be an OSC to change the border color...

cpsdqs commented 7 years ago

muted? The adjacent cell color thing meant that the cells along the perimeter would essentially just get bigger

MightyPork commented 7 years ago

yeah I don't really like that

something like this: sss

cpsdqs commented 7 years ago

could also do this with almost zero CSS hacks (at least in Safari, Chrome's backdrop-filter is still incredibly glitchy but behind a flag so no one will notice) an image. can't be bothered to do an alt text. sorry screen readers

MightyPork commented 7 years ago

that wouldn't be bad

cpsdqs commented 7 years ago

Implemented https://github.com/espterm/espterm-front-end/commit/aa41cf512e03946212106af6afb3d974e362463d

MightyPork commented 7 years ago

i'll have a look - after making back-end compile again xD

cpsdqs commented 7 years ago

haha, blurry

blurry margins with vim
MightyPork commented 7 years ago

looks nice but u may wanna fix that horrible overlapping triangle :p

cpsdqs commented 7 years ago

you mean the powerline symbols? that's the font's fault

MightyPork commented 7 years ago

idk what's a powerline but looks like it could be drawn using a polygon... screenshot_20170928_202328

cpsdqs commented 7 years ago

hm good idea, though I seriously doubt anyone would use vim with powerline (or in this case, airline) in ESPTerm xD

MightyPork commented 7 years ago

I mean no, but they're nice symbols :P I'll add them together with the block drawing characters to a new codepage