search

esr360 / Kayzen-GS

Kayzen-GS is a powerful framework for building responsive grid systems for the web
http://kayzen.gs
MIT License
29 stars 3 forks source link

Added ability to push and pull #6

Closed visualcookie closed 8 years ago

visualcookie commented 8 years ago

Created two mixins for the new push and pull classes. This method is used by almost any grid.

Guess Issue #2 can be closed after merged.

esr360 commented 8 years ago

Great, awesome stuff.

We need to get this code into the source Scss files though so that these push/pull classes are created dynamically. Looking at how you've done it, it shouldn't be too difficult. I will have a play this weekend, unless you would like to give it a go?

Also a nice way to avoid repeating position: relative; on each push/pull class might be to do something like:

[class*="push-"],
[class*="pull-"] {
    position: relative;
}
visualcookie commented 8 years ago

Will get into it. Totally missed that out. Only added it to flow-row.

Gonna see if I'm able to get it done by Sunday.

visualcookie commented 8 years ago

I modified the push and pull a bit and inserted the source to line 274 in the kayzen-gs.scss. Got one problem there now. If the column is pulled, there's still a margin-left. I don't want to use !important for that. Maybe you got a clue.

esr360 commented 8 years ago

I agree not to use !important, it can most likely be achieved without.

I've been thinking about this in the back of my mind since you posted, I'll take a proper look at your commits when I next have time, probably this weekend, and we can get it sorted then :)

esr360 commented 8 years ago

Branch version_2_beta has ability to push and pull columns. Not quite ready for use yet but won't be long before an official release with the feature.

esr360 commented 8 years ago

Ability to push and pull columns is now available on master branch through version 2. Thanks for the idea!