search

esr360 / Kayzen-GS

Kayzen-GS is a powerful framework for building responsive grid systems for the web
http://kayzen.gs
MIT License
29 stars 3 forks source link

How "stack" reacts in own grid systems? #7

Open ghost opened 6 years ago

ghost commented 6 years ago 
@include column((
    'width'        : 'full', 
    'type'         : null, 
    'stack'        : kgs-option('col-break'), 
    'mobile-first' : kgs-setting('mobile-first'),
    'respond-to'   : null
))

'stack': This value determines at which breakpoint your columns should stack on top of each other when scaling down. The default value is based off the default value of the main grid system, which evaluates to break-3, which by default evaluates to 940px.

Isn't "row" the element that should has the "stack" value not the "column", like this example:

<div class="row stack-break-2">                    
    <div class="span-3">Sidebar</div>
    <div class="span-9">Article</div>
</div>

I know they are two different cases but isn't it should be the same concept?

Thanks for your amazing work.

esr360 commented 6 years ago

Hi @institution-site, thanks for the report. I think you're right yes, this behavior should be handled by the row and not the column. I can't think of a situation where it would make sense to have different columns in a row stack at different widths.