Basler: make it work with pylon 3, 4 and 5

esrf-bliss / Lima-camera-basler

Lima basler plugin

lima.blissgarden.org

GNU General Public License v3.0

4 stars 26 forks source link

Basler: make it work with pylon 3, 4 and 5 #14

Closed tiagocoutinho closed 8 years ago

tiagocoutinho commented 8 years ago

This PR includes changes from PR #13 so you should merge #13 before this one This introduces a binary incompatibility since it changes the size of BaslerCamera by adding the auto_init_term_ member (commit 1358f27). If you think this is a problem I will be happy to remove this. I just added because it seemed a more elegant solution to make sure pylon is properly initialized.

laurent-claustre commented 8 years ago

the change for documentation is not enough, is missing some information explaining the new configuration using the serial number and the compatibility with pylon 4 and 5. Same thing for the device server reference doc in applications/tango/python/doc/camera/basler.rst.

tiagocoutinho commented 8 years ago

Ok, I added more info to the documentation. Can you please check to see if it is enough? Thanks!