search

esrf-bliss / Lima-camera-simulator

Lima camera plugin for testing
GNU General Public License v3.0
1 stars 1 forks source link

Odd frame sizes #2

Open woutdenolf opened 2 years ago

woutdenolf commented 2 years ago

To simulate real detector like the Pilatus1M we need odd frame sizes.

This is currently not supported: https://github.com/esrf-bliss/Lima-camera-simulator/blob/d73aa87696ec7a50da69aa7d640db2308d631710/src/SimulatorFrameBuilder.cpp#L126-L133

sdebionne commented 2 years ago

Odd frame dimensions is rather... odd. I can't remember why we have this limitation from the top of my head, especially if binning is not used... For my records, what is the frame size of the Pilatus1M (Dectris or SLS)?

woutdenolf commented 2 years ago 
>>> from pyFAI.detectors import detector_factory
>>> detector_factory("Pilatus1M").shape
(1043, 981)
>>> detector_factory("Pilatus2M").shape
(1679, 1475)
woutdenolf commented 2 years ago

Seems that odd dimensions are very common:

https://github.com/silx-kit/pyFAI/blob/master/pyFAI/detectors/_dectris.py

sdebionne commented 2 years ago

I see, this is how pyFAI sees the image reconstructed (with the gaps and the pixels that are larger on the side of chips/modules). The vendor specification says otherwise:

https://www.dectris.com/detectors/x-ray-detectors/eiger2/eiger2-for-synchrotrons/eiger2-x-cdte/#Specifications

That being said, we can probably support odd pixel dimensions without too much effort.

woutdenolf commented 1 year ago

@sdebionne It would be very helpful if this could be done before the first ewoks training in May.