search

esrf-bliss / Lima

Library for Image Acquisition
https://lima1.rtfd.io
GNU General Public License v3.0
39 stars 71 forks source link

check if hdf5 attribute exists before creating it #111

Closed weninc closed 4 years ago

weninc commented 4 years ago

fix #109

weninc commented 4 years ago

ping @laurent-claustre

sdebionne commented 4 years ago

LGTM, thanks!

laurent-claustre commented 4 years ago

Hi @weninc, the merge is ongoing on our CI on gitlab.esrf.fr. When done, github.com will be updated and your PR too. For which detectors are you using Lima on MaxIV beamlines?

weninc commented 4 years ago

Great thank you. We are using Lima for quite a few detectors here at MAX IV including Andor3, Pilatus, Merlin and Xspress3

laurent-claustre commented 4 years ago

Our CI pipeline is broken under windows with due to a conda issue, once fix I will merge. Sorry for the delay.

sdebionne commented 4 years ago

@weninc Sorry it took so long to merge, we were affected by conda/conda#9578.

weninc commented 4 years ago

No Problem. Thanks a lot for getting it merged