esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
11 stars 8 forks source link

No hardcoding of mailadresses/phone numbers on Squire #239

Open Ndoll1 opened 2 years ago

Ndoll1 commented 2 years ago

In regard to scrubbing of data, but also that it is a better practice, we should try to limit hardcoding of email addresses and/or phone numbers. It is better to request those from the database connected to the website.

Example; when a mail changes, it only needs to be changed once in the database and then it is changed all over the server.

DutcherNL commented 2 years ago

The few e-mails that are hardcoded are so incredibly consistent (bg@, bestuur@ board@) that writing complex code for database retrieval of fixed instances is something that it not worth the hassle. If you want to prevent automated code scrubbing we could implement a templatefilter named 'knightmail' that adds the e-mail appendix so it's less obvious if you prefer that.