esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
9 stars 7 forks source link

Alternative starting time for slot during activities #241

Open Ndoll1 opened 2 years ago

Ndoll1 commented 2 years ago

For activities that will take >1 evening and might have different starting times of for example boardgames (Long boardgame days), it might be a good cause to be able to add an alternative starting time (and day).

Sometimes it also happen that a boardgame starts a bit earlier on the boardgame evening, specifically for explaining the game.

EricTRL commented 2 years ago

Note: There are already start_date and end_date fields on the ActivitySlot model; they're just not shown anywhere and are hidden on the admin panel as well.

Implementing this would only require modifying the ActivitySlot's ModelAdmin and the frontend template for slot blocks.

DutcherNL commented 2 years ago

It may look like a simple first issue, but it has a lot of additional challenges that should not be underestimated; how do you communicate the different starting time? Should this be availlable for all activities or only particular ones? Who should have the rights to create slots with alternative starting and end times? There is a certain balance in how much information one can share without it getting lost in between all other information. In the initial version of the site (prior to the december 2020 update on the activity slots) it used to be present. That is why it's still availlable on the database. However it added a lot of complexity in an attempt to display all slot information (title, description, who joined, join button) that having a time displayed muddled the ease of use. A different starting time may also have implications on the calendar, should different slot times be present on the calendar and if it's not on the calendar, how does one ensure that the user knows they (can/has) assigned themself to a slot with different start and end times.

EricTRL commented 2 years ago

These alternative start/end datetimes weren't used prior to the December 2020 update (with the exception of them being visible in the admin panel, IIRC). I agree with the remarks about issues with displaying all information though, (which is also why it was never fully implemented in the first place, even though the database fields were already there).

Regarding how it should be displayed on the calendar: not at all. Alternative locations for slots aren't displayed there either, and there's no reason for them to be because they're only applicable to those that have registered for that specific slot. Furthermore, there are no special precautions taken to ensure that a user knows they signed up for a slot with a different location. So far, I think we haven't had any issues with this (E.g. boardgames@home in 2020, or the odd Uitkijktoren-location during the standard boardgame evenings).

On the other hand, every time I wanted an "alternative end time" I've simply included this in the description of my slot. For instance, I've mentioned several times that a boardgame should well end before 23.00h because I needed to use public transport.

Ndoll1 commented 2 years ago

I once had an issue with a member signing up to play a game at my place and he thought it was online even though it was mention to be at location. Eventually he came, 30 mins late -.- .

I think the option to add a different starting time should not be there always. It is useful for specific activities, like Long board game days and for instance the video game activity this friday.