search

esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
10 stars 8 forks source link

Membership File Validation #28

Open EricTRL opened 5 years ago

EricTRL commented 5 years ago

Some fields are only required in some scenarios and some fields are mutually exclusive. E.g. Having a TU/e card number and external card number entered at the same time is unneeded, and a TU/e card number can only be entered if actually studying at the TU/e. Both cases are not necessarily true: there's a bit of a grace period between finishing your studies and losing access to TU/e-facilities.

Can be fixed using model validation as mentioned in the docs or on this StackOverflow thread.

DutcherNL commented 1 year ago

What still needs to be validated what isn't yet validated?

EricTRL commented 1 year ago

What still needs to be validated what isn't yet validated?

I checked the model file, and the only that comes to mind is the fact that you'll need to leave a phone number when you have a keycode or external card (possibly tue student card). From the user-side, this wouldn't change much (if they're keen on removing info they can add fake data anyways). For admins/the board, this can somewhat "ensure" that keycodes/cards are not given to people who are hard to reach.