esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
11 stars 8 forks source link

Bump minimum Python version to 3.8 #285

Closed EricTRL closed 2 years ago

EricTRL commented 2 years ago

Our server is running Python 3.8 too, and it seems like some dependencies (importlib-metadata) of our dependencies (martor) broke in their latest release. This specific broken dependency isn't actually used in Python 3.8 though, as it's a backport. This is also why tests run successfully locally on later Python versions.

codecov[bot] commented 2 years ago

Codecov Report

Base: 95.29% // Head: 95.36% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (913e83e) compared to base (6e56f9f). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #285 +/- ## ========================================== + Coverage 95.29% 95.36% +0.06% ========================================== Files 115 115 Lines 4698 4766 +68 Branches 467 467 ========================================== + Hits 4477 4545 +68 Misses 149 149 Partials 72 72 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.36% <ø> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/esrg-knights/Squire/pull/285?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [inventory/models.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-aW52ZW50b3J5L21vZGVscy5weQ==) | `100.00% <0.00%> (ø)` | | | [committees/models.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-Y29tbWl0dGVlcy9tb2RlbHMucHk=) | `100.00% <0.00%> (ø)` | | | [achievements/views.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-YWNoaWV2ZW1lbnRzL3ZpZXdzLnB5) | `100.00% <0.00%> (ø)` | | | [activity\_calendar/api.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-YWN0aXZpdHlfY2FsZW5kYXIvYXBpLnB5) | `100.00% <0.00%> (ø)` | | | [utils/templatetags/paginator.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-dXRpbHMvdGVtcGxhdGV0YWdzL3BhZ2luYXRvci5weQ==) | `100.00% <0.00%> (ø)` | | | [utils/templatetags/field\_tags.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-dXRpbHMvdGVtcGxhdGV0YWdzL2ZpZWxkX3RhZ3MucHk=) | `100.00% <0.00%> (ø)` | | | [core/templatetags/martor\_render.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-Y29yZS90ZW1wbGF0ZXRhZ3MvbWFydG9yX3JlbmRlci5weQ==) | `100.00% <0.00%> (ø)` | | | [achievements/templatetags/negate.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-YWNoaWV2ZW1lbnRzL3RlbXBsYXRldGFncy9uZWdhdGUucHk=) | `100.00% <0.00%> (ø)` | | | [utils/templatetags/generic\_field.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-dXRpbHMvdGVtcGxhdGV0YWdzL2dlbmVyaWNfZmllbGQucHk=) | `100.00% <0.00%> (ø)` | | | [membership\_file/auto\_model\_update.py](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-bWVtYmVyc2hpcF9maWxlL2F1dG9fbW9kZWxfdXBkYXRlLnB5) | `100.00% <0.00%> (ø)` | | | ... and [22 more](https://codecov.io/gh/esrg-knights/Squire/pull/285/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.