esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
11 stars 8 forks source link

Add TSV, ODS & XLSX to export options #305

Closed LenaWil closed 1 year ago

LenaWil commented 1 year ago

TSV with BOM works fine, but Excel doesn’t open them by default. ODS doesn’t work properly if both unicode and Excel are used. XLSX of course does work correctly, but I don’t want to use a microsoft specific format.

Fixes #301.

I should still write tests, but I would like others to review it first.

LenaWil commented 1 year ago

Maybe I should also include a BOM in the .csv exports… what are y’alls thought on it?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.90% and no project coverage change

Comparison is base (9d83be4) 95.77% compared to head (44abd0c) 95.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #305 +/- ## ======================================= Coverage 95.77% 95.77% ======================================= Files 132 132 Lines 5541 5544 +3 Branches 883 884 +1 ======================================= + Hits 5307 5310 +3 Misses 160 160 Partials 74 74 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.77% <90.90%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/esrg-knights/Squire/pull/305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [membership\_file/admin.py](https://codecov.io/gh/esrg-knights/Squire/pull/305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-bWVtYmVyc2hpcF9maWxlL2FkbWluLnB5) | `93.54% <90.90%> (+0.15%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LenaWil commented 1 year ago

Okay, how extensive should the tests be?

DutcherNL commented 1 year ago

Okay, how extensive should the tests be?

Depends on how important/ how easy it is to accidentally break it. In your case I would only add a test that ensures export_data indeed adds the 'zero width no break space' to the beginning of the file.