esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
10 stars 8 forks source link

“Smart” (unicode) quotation marks with the committee nicknames of people #321

Closed LenaWil closed 1 year ago

LenaWil commented 1 year ago

This should make the quotation marks around the nick-names of committee members nicer looking.

I wrote this on my mobile phone during the downtime of an IW training and therefore haven’t actually tested it yet.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02% :warning:

Comparison is base (19f7f25) 95.86% compared to head (48c80bb) 95.84%. Report is 1 commits behind head on master.

:exclamation: Current head 48c80bb differs from pull request most recent head 401f866. Consider uploading reports for the commit 401f866 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #321 +/- ## ========================================== - Coverage 95.86% 95.84% -0.02% ========================================== Files 161 145 -16 Lines 7106 6113 -993 Branches 1164 968 -196 ========================================== - Hits 6812 5859 -953 + Misses 193 174 -19 + Partials 101 80 -21 ``` | [Flag](https://app.codecov.io/gh/esrg-knights/Squire/pull/321/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/esrg-knights/Squire/pull/321/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | `95.84% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#carryforward-flags-in-the-pull-request-comment) to find out more. [see 24 files with indirect coverage changes](https://app.codecov.io/gh/esrg-knights/Squire/pull/321/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.