search

esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
11 stars 8 forks source link

Martor CI invalid url name #325

Closed EricTRL closed 2 weeks ago

EricTRL commented 1 year ago

Martor changed internally somewhere between version 1.6.14 (my machine), 1.6.16 (server), and 1.6.28 (current) where configuration is no longer properly read.

The following error is thrown in the CI runs for #289 #322 and #323 django.urls.exceptions.NoReverseMatch: Reverse for 'martor_markdownfy' not found. 'martor_markdownfy' is not a valid view function or pattern name.

The culprit is line 35 in /martor/widgets.py, where the reverse-url "martor_markdownfy" was hardcoded. We instead use "martor_markdownify".

The release notes don't mention a thing, so the entire setup should be checked before we upgrade Martor to a more recent version.

Cause of the issue is this commit, which was merged to master in 1.6.27

EricTRL commented 1 year ago

Martor version was temporarily limited in https://github.com/esrg-knights/Squire/pull/326/commits/dd3e5c6ce6eda5401db9aab7216d40c4273c4a8d and merged with master in #326. Version limit can be removed once a fix is released in Martor.