esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
10 stars 8 forks source link

Fix: Inactive committee members (display) + multiple global archive addresses #326

Closed EricTRL closed 1 year ago

EricTRL commented 1 year ago

Fixed an issue where the server status page incorrectly mentioned a committee alias was outdated when an inactive member was part of that committee. Actual behaviour is unchanged; inactive members were still added to the committee's alias (as intended).

Fixed an issue where a crash would occur when multiple global committee archive addresses were set up in mailcowconfig.json

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (95505d3) 95.86% compared to head (19f7f25) 95.86%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #326 +/- ## ======================================= Coverage 95.86% 95.86% ======================================= Files 161 161 Lines 7106 7106 Branches 1164 1164 ======================================= Hits 6812 6812 Misses 193 193 Partials 101 101 ``` | [Flag](https://app.codecov.io/gh/esrg-knights/Squire/pull/326/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/esrg-knights/Squire/pull/326/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | `95.86% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/esrg-knights/Squire/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [mailcow\_integration/admin\_status/views.py](https://app.codecov.io/gh/esrg-knights/Squire/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-bWFpbGNvd19pbnRlZ3JhdGlvbi9hZG1pbl9zdGF0dXMvdmlld3MucHk=) | `95.21% <100.00%> (ø)` | | | [utils/viewcollectives.py](https://app.codecov.io/gh/esrg-knights/Squire/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#diff-dXRpbHMvdmlld2NvbGxlY3RpdmVzLnB5) | `89.42% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.