codecov[bot]
commented
9 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e84d775) 96.03% compared to head (6a0f77a) 95.84%.:exclamation: Current head 6a0f77a differs from pull request most recent head 42b38bb. Consider uploading reports for the commit 42b38bb to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #340 +/- ## ========================================== - Coverage 96.03% 95.84% -0.20% ========================================== Files 163 161 -2 Lines 7650 7118 -532 Branches 1247 1166 -81 ========================================== - Hits 7347 6822 -525 + Misses 196 194 -2 + Partials 107 102 -5 ``` | [Flag](https://app.codecov.io/gh/esrg-knights/Squire/pull/340/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/esrg-knights/Squire/pull/340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | `95.84% <ø> (-0.20%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The hue was not consistent. This extra line of CSS makes it consistent with the rest of the theme, while keeping the same luminance & chroma values. While this colour is only in REC. 2020, and not in sRGB and barely not in P3, and it was most likely picked because Nicky needed to pick a green colour, picking a different colour means I would have to be creative, and I am tired. 😛
I did not actually test this yet, but it should make the colours more consistent.Update: tested it, it’s an improvement. However I still look into #275 because it still looks kinda bad.