esrg-knights / Squire

A re-introduction of the WebApp for ESRG Knights of the Kitchen Table.
https://www.kotkt.nl/
GNU General Public License v3.0
10 stars 8 forks source link

Update Mailcow API 2024-08a #349

Closed EricTRL closed 2 weeks ago

EricTRL commented 2 weeks ago

Mailcow's API was changed in one of the recent updates that we applied to our installation. This changes the way Squire handles the API:

Screenshot ![image](https://github.com/user-attachments/assets/07f46d27-0f1d-487e-96bf-c185a554e224)
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 62.59542% with 98 lines in your changes missing coverage. Please review.

Project coverage is 96.57%. Comparing base (02b3f6b) to head (5398d42).

Files with missing lines Patch % Lines
core/admin_status/views.py 28.00% 36 Missing :warning:
mailcow_integration/api/interface/base.py 68.23% 20 Missing and 7 partials :warning:
mailcow_integration/api/interface/mailbox.py 68.75% 10 Missing and 10 partials :warning:
mailcow_integration/api/interface/alias.py 56.66% 7 Missing and 6 partials :warning:
mailcow_integration/squire_mailcow.py 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #349 +/- ## ========================================== - Coverage 97.19% 96.57% -0.63% ========================================== Files 234 236 +2 Lines 14332 14564 +232 Branches 906 945 +39 ========================================== + Hits 13930 14065 +135 - Misses 261 334 +73 - Partials 141 165 +24 ``` | [Flag](https://app.codecov.io/gh/esrg-knights/Squire/pull/349/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/esrg-knights/Squire/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights) | `96.57% <62.59%> (-0.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esrg-knights#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.