search

ess-dive / docker-metacat

Other
0 stars 0 forks source link

build metacat.properties dynamically #2

Closed helbashandy closed 5 years ago

helbashandy commented 5 years ago

In GitLab by @vchendrix on Oct 12, 2017, 06:48

Upgrading metacat adds changes to the default metacat.properties that need to be merged into an existing metacat configuration. The idea here is to allow the docker-metacat user to create a file with ony the set of properties that need to be modifed. This file will then be merged with the default metacat.properties file in the docker image. If a property being set no longer exists in the upgraded version's default metact.properties the docker image should exit in failure with a detailed message.

helbashandy commented 5 years ago

In GitLab by @metamattj on Oct 12, 2017, 09:26

Val -- the metacat admin utility already has a feature for merging in a set of backup properties during upgrade. As I mentioned the other day, we made a conscious decision to require admins to step through the upgrade to check that nothing untoward happened, and that they are ready for the database upgrade. But I think it would be good to provide an 'unattended' mode that simply merges properties forward. So you may not need a special facility in the docker scripts to do this.

helbashandy commented 5 years ago

In GitLab by @vchendrix on Oct 12, 2017, 10:27

The problem with this right now is that the metacat properties file is mounted in webapp/metacat/WEB-INF/metacat.properties. Which breaks any hope at an upgrade because the new properties in the upgraded version will be lost unless they can be merged.

So what you are saying is that we should bind mount to the backup properties directory and let metacat admin utility merge the files. This would require an enhancment to the metacat admin utility to add an 'unattended' mode. Correct?

This should be added to our list of metacat features to add. :)

helbashandy commented 5 years ago

In GitLab by @metamattj on Oct 12, 2017, 12:01

Exactly.

helbashandy commented 5 years ago

In GitLab by @vchendrix on Oct 12, 2017, 17:15

closed via commit c2a645607b37758cb668ea64b8192757d4229fc3