ess-dmsc / h5cpp

C++ wrapper for the HDF5 C-library
https://ess-dmsc.github.io/h5cpp/
GNU Lesser General Public License v2.1
116 stars 19 forks source link

parameters of library_version_bounds are swapped #604

Closed yuelongyu closed 2 years ago

yuelongyu commented 2 years ago

as title said, the first argument should be low and second is high.

void FileAccessList::library_version_bounds(LibVersion high, LibVersion low) const {
  if (0 > H5Pset_libver_bounds(static_cast<hid_t>(*this),
                               static_cast<H5F_libver_t>(high),
                               static_cast<H5F_libver_t>(low))) {
    error::Singleton::instance().throw_with_stack("Failure setting the library version bounds!");
  }
}
yuelongyu commented 2 years ago

resolved in PR #605