search

ess-dmsc / kafka-to-nexus

(Mirror: moved to https://gitlab.esss.lu.se/ecdc/ess-dmsc/kafka-to-nexus) Writes NeXus files from experiment data streamed through Apache Kafka.
BSD 2-Clause "Simplified" License
2 stars 4 forks source link

ECDC-3142 Ignore broker addresses sent in JobStart message #659

Closed danesss closed 1 year ago

danesss commented 1 year ago

Issue

https://jira.esss.lu.se/browse/ECDC-3142

Description of work

We want to decouple the Kafka addresses seen by Nicos and the Filewriter. In this commit we stop honouring the address sent by Nicos and use one of the addresses already known by the Filewriter.

Note that this is a temporary solution to mitigate the coupling with Nicos. We want to refactor the Kafka configuration in the filewriter (see ECDC-3118), possibly resulting in a single "kafka-config" for all librdkafka settings. The code in this commit should use such new configuration facility to set the broker address instead of using the address from JobPoolURI, which is quite arbitrary.

Nominate for Group Code Review

Reminder

Changes should be documented in changes.md

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5227 3506 67% For more detail see Cobertura report in Jenkins interface