ess-dmsc / kafka-to-nexus

(Mirror: moved to https://gitlab.esss.lu.se/ecdc/ess-dmsc/kafka-to-nexus) Writes NeXus files from experiment data streamed through Apache Kafka.
BSD 2-Clause "Simplified" License
2 stars 4 forks source link

Update librdkafka to version 2 #675

Closed amues closed 1 year ago

amues commented 1 year ago

Issue

ECDC-3326

Description of work

Update librdkafka to version 2.

Nominate for Group Code Review

Reminder

Changes should be documented in changes.md

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5489 3772 68% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5489 3770 68% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5489 3771 68% For more detail see Cobertura report in Jenkins interface

danesss commented 1 year ago

@amues I was thinking on waiting some time for v2 to be thoroughly tested, but it's good that you triggered it and that tests are passing.

Do you know if the the new Openssl in this librdkafka is useful for us in the context of enabling Kafka SSL?

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5489 3772 68% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5489 3772 68% For more detail see Cobertura report in Jenkins interface

amues commented 1 year ago

@danesss I don't know if the new OpenSSL version brings any useful changes, other than being the new major LTS release with support until 2026.