ess-dmsc / kafka-to-nexus

(Mirror: moved to https://gitlab.esss.lu.se/ecdc/ess-dmsc/kafka-to-nexus) Writes NeXus files from experiment data streamed through Apache Kafka.
BSD 2-Clause "Simplified" License
2 stars 4 forks source link

Feat(metadata): Write units attribute in derived datasets (metadata) #692

Closed danesss closed 1 year ago

danesss commented 1 year ago

Issue

ECDC-3368

Description of work

We modify Value class to also receive a function to write attributes and assume that Value represents a dataset to be written with or without attributes. Previously, Value could be called separately with a group/dataset and a function to respectively create a dataset in the group / attribute in the dataset. I do not see the usefulness of such generalisation, Value class is used exclusively to create derived datasets, so it seems simpler to model it as a dataset and nothing else.

Checklist

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5626 3787 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5626 3785 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5626 3786 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5626 3786 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 1 year ago

Code Coverage (Lines Exec Cover) TOTAL 5626 3786 67% For more detail see Cobertura report in Jenkins interface