ECDC-3494 honour hdf prefix setting

[danesss]

Issue

https://jira.esss.lu.se/browse/ECDC-3494

Description of work

• Change the default storage directory for data files to be the current working directory, and not the root of the filesystem's mount point.

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5623 3790 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5623 3791 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5623 3792 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5623 3785 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5623 3785 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5623 3785 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5624 3791 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5624 3785 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3792 67% For more detail see Cobertura report in Jenkins interface

[ggoneiESS]

Line 83 in src/tests/MasterTests.cpp needs a check that filename isn't blank, otherwise you're going to end up deleting the folder and causing issues

& the comment on the CLI option is a bit confusing now - isn't it actually the relative path you're giving, not absolute? That would make me use something like hdf-output-prefix = "/ess/data/ymir/2022"

which means we would write to /whatever/folder/we/were/in/ess/data/ymir/2022/

so the comment should say 'addLineBreaks("Relative path to directory which gets "', no?

[danesss]

isn't it actually the relative path you're giving, not absolute?

If the config option is unset, then we use current working directory. If the option is set, it should be set with an absolute path.

[danesss]

Line 83 in src/tests/MasterTests.cpp needs a check that filename isn't blank, otherwise you're going to end up deleting the folder and causing issues

@ggoneiESS Fixed, thanks!

[ggoneiESS]

isn't it actually the relative path you're giving, not absolute?

If the config option is unset, then we use current working directory. If the option is set, it should be set with an absolute path.

Do we need to check an absolute path has been given then? It looks like it should be caught in FileWriterTask.cpp:58, but not 100% sure. Might be cleaner to have a check, but I can't see any on any of the inputs

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3792 67% For more detail see Cobertura report in Jenkins interface

[danesss]

Do we need to check an absolute path has been given then? It looks like it should be caught in FileWriterTask.cpp:58, but not 100% sure. Might be cleaner to have a check, but I can't see any on any of the inputs

Okay. I've instead checked if the logic actually supports relative paths and seems fine. So I'm restoring the former help message that allows relative/absolute paths

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3799 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3792 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3790 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3791 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3792 67% For more detail see Cobertura report in Jenkins interface

[cow-bot]

Code Coverage (Lines Exec Cover) TOTAL 5626 3798 67% For more detail see Cobertura report in Jenkins interface