ess-dmsc / kafka-to-nexus

(Mirror: moved to https://gitlab.esss.lu.se/ecdc/ess-dmsc/kafka-to-nexus) Writes NeXus files from experiment data streamed through Apache Kafka.
BSD 2-Clause "Simplified" License
2 stars 4 forks source link

stop_time to end_time and NX_DATE_TIME #711

Closed ggoneiESS closed 10 months ago

ggoneiESS commented 11 months ago

Issue

Changed stop_time to end_time and changed the time format from nanoseconds to ISO8601 in line wiht NX_DATE_TIME

Description of work

New method to account for the fact we are using a string rather than a time in the dataset (which is better in general anyway) and then use of to do the conversion for formats; chrono fortmat options would be best but that means C++20

Checklist

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3837 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3834 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5695 3836 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5696 3837 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5694 3835 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5697 3838 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5697 3838 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5697 3844 67% For more detail see Cobertura report in Jenkins interface

cow-bot commented 11 months ago

Code Coverage (Lines Exec Cover) TOTAL 5697 3837 67% For more detail see Cobertura report in Jenkins interface

ggoneiESS commented 11 months ago

Let's discuss this tomorrow before the quick catch-up and the code hour? 0930? Writing NX_DATE_TIME as strings is actually quite a different puzzle compared to before, since it uses a very different NeXus data type. I also don't understand how we will write times (with timezones or UTC?)