Fixed build for GHC 8.4.3, stack resolver switched to lts-12.9

[qrilka]

Fixes #25 @essandess I would also advise to use some CI to make sure that the package builds with at least the latest 3 GHC versions. Also if you plan to maintain the package it makes sense to publish a new version on Hackage - the current one there - http://hackage.haskell.org/package/adblock2privoxy seems to be too old

[essandess]

Thanks!

1. I haven't done CI before, much less with stack. Would you be able to recommend an approach from the many auto-suggested by GitHub?
2. I'm aware of that, but haven't wanted to step on the original developer's toes, who still maintains an independent git repo. My plan is to integrate feedback from GitHub for a while longer, then ask if the updated repo could be added to Hackage.

[qrilka]

I think Travis is most frequently used for Haskell projects for Stack you could check out https://docs.haskellstack.org/en/stable/travis_ci/ Regarding the original repo - did you contact the author? If you plan to take over maintainership of the package then there is a procedure to do that.

[wmyrda]

2. I'm aware of that, but haven't wanted to step on the original developer's toes, who still maintains an independent git repo. 

Which repo would that be? The only one I was aware of was http://projects.zubr.me/browser/adblock2privoxy which has not been updated for 3 years now...

[essandess]

@wmyrda Yes, zubr's original repo is the one represented in hackage. Let's make the improvements you've suggested then follow the procedure that @qrilka points to above.

[essandess]

@qrilka May I ask for some Haskell CI assistance?

I followed your suggestion and linked this repo to travis-ci. I have a mostly-working .travis.yml that I adopted from commercialhaskell for ghc-8.4.3, however, the stack command fails because I am apparently in the wrong directory and it doesn’t see stack.yml:

…
Error parsing targets: The specified targets matched no packages.
Perhaps you need to run 'stack init'?

This should be a trivial fix, but I’ve checked the obvious stuff and don’t see the issue.

Would you be able to point to a simple .travis.yml for building on macOS with ghc-8.4.3? Or point to the error in .travis.yml?

See https://api.travis-ci.org/v3/job/431239222/log.txt for the latest build fail.

[qrilka]

Just wondering - why did you choose only GHC 8.4.3 and OSX? :) As for the error - I think you need to either cd adblock2privoxy as a 1st step both for install and script or just move your stack to the root of the repo and replace

packages:
- '.'

with

packages:
- adblock2privoxy

and also it makes sense to add adblock2privoxy-utils as a 2nd package so both will get built on Travis

[essandess]

@qrilka Thanks! That did it—just a single cd required in install.

About the build profile, I’m starting with the one I use. Crawl–walk–run. I’ll add more where there’s demand.