Closed wmyrda closed 5 years ago
As a workaround one may use sed -i -e 's:*.:.:' /etc/privoxy/ab2p.system.action
after running adblock2privoxy to automatically fix offending lines.
@essandess
For pernament fix please add following fix to the code. It patches template resposible for the problem.
diff -Naur adblock2privoxy-9999.old/adblock2privoxy/templates/ab2p.system.action adblock2privoxy-9999/adblock2privoxy/templates/ab2p.system.action
--- adblock2privoxy-9999.old/adblock2privoxy/templates/ab2p.system.action 2018-06-03 11:22:27.374247091 +0200
+++ adblock2privoxy-9999/adblock2privoxy/templates/ab2p.system.action 2018-06-03 11:23:10.974250166 +0200
@@ -28,5 +28,5 @@
#workaround for gzip handling privoxy bugs
{ +prevent-compression }
- *.yahoo.com
- *.amazon.com
+ .yahoo.com
+ .amazon.com
Note to self: fix this directly in the file ab2p.system.action.
@wmyrda I see leading spaces in this file, which I believe is incorrect privoxy syntax. Have you gone back and checked the privoxy
dox to make sure removing the leading *
won’t lead to side effects? If so, do you mind tossing in a link?
I’ll come back and address this as soon as I have a moment to do so and check it.
Just checked for it and removing space does not help after bringing back *
privoxy 3.0.26 still crashes
Only side effect of not having { +prevent-compression }
is that particular site would not be filtered by privoxy. I do not think that this section belongs to the file which would be regenerated every time a2p is used at all. Those entries have to be manually generated anyways as they could not be derived from any adblock list. Personally I use file to which I add hosts on which I stumble upon and where compression is undesired.
I recommend to remove it completely and add it to separate file. My current example below
diff -Naur adblock2privoxy-9999.old/adblock2privoxy/templates/ab2p.system.action adblock2privoxy-9999/adblock2privoxy/templates/ab2p.system.action
--- adblock2privoxy-9999.old/adblock2privoxy/templates/ab2p.system.action 2018-08-19 09:18:53.334664654 +0200
+++ adblock2privoxy-9999/adblock2privoxy/templates/ab2p.system.action 2018-08-19 09:30:40.406010437 +0200
@@ -25,8 +28,3 @@
{-block}
TAG:^ab2p-unblock-s$
-
-#workaround for gzip handling privoxy bugs
-{ +prevent-compression }
- *.yahoo.com
- *.amazon.com
gzipfix.action -- add actionsfile gzipfix.action
to privoxy's config
file to use it
# Workaround for gzip handling privoxy bugs
{ +prevent-compression }
#Arabic
\.alalam\.ir
\.muraselon\.com
#English
\.almasdarnews\.com
\.amazon\.com
\.belden\.com
\.cyberciti\.biz
\.defence24\.com
^electronicintifada\.net
\.eurasiafuture\.com
\.europa\.eu
\.foreignpolicyjournal\.com
\.globalresearch\.ca
\.kbb\.com
\.kodi\.tv
^linoxide\.com
^linuxconfig\.org
\.mintpressnews\.com
\.opensubtitles\.org
\.phoronix\.com
\.pikcat\.com
\.pictasite\.com
\.pointdeveloper\.com
\.prohavit\.com
\.russia-insider\.com
\.skepticalraptor\.com
\.sott\.net
\.targus\.com
^tune\.pk
\.yahoo\.com
\.youtube\.com
\.veteranstoday\.com
#Polish
\.autocentrum\.pl
^bezux\.pl
^businessinsider\.com\.pl
\.centrumdruku\.com\.pl
\.centrumpapieru\.pl
^chamsko\.pl
\.chip\.pl
^ciekawe\.org
\.computerworld\.pl
\.computerworld\.pl
\.defence24\.pl
^demotywatory\.pl
^dobry-kon\.pl
^dorzeczy\.pl #still does not filter
\.domiporta\.pl
\.download\.net\.pl
^echaswantewita\.blogspot\.com #still does not filter
\.fabrykawafelkow\.pl
\.fangol\.pl
\.filmweb\.pl
^fortnitepolska\.pl
\.homify\.pl
\.hotfrog\.pl
\.hulahop\.pl
^kariera\.pl
\.komputerswiat\.pl
\.lidl\.pl
\.lublin112\.pl
\.idg\.pl
^innemedium\.pl
^inwestycje-rzeszow\.pl
^jejportal\.pl
\.jobisjob\.pl
\.makehomeeasier\.pl
\.mamissima\.pl
\.media2\.pl
\.miniminiplus\.pl #still does not filter
\.meble\.pl
^napisy24\.pl
^nf\.pl #still does not filter
^ototorun\.pl
^oko\.press
^paczaizm\.pl
\.pch24\.pl
\.pcworld\.pl
^plonszczak\.pl
^podkarpackisport\.pl
\.programosy\.pl
^pupilo\.pl
\.purepc\.pl
\.seat-auto\.pl
^selsey\.pl
^silesion\.pl
^socialpress\.pl
\.sosrodzice\.pl
^specjalski\.pl
^stooq\.pl
^tojuzbylo\.pl
^tosport\.pl
^tylkoastronomia\.pl #still does not filter
^tylkomedycyna\.pl
^tylkonauka\.pl
^superdania\.pl
^media2\.pl
^mszana-dolna\.eu
^niezlomni\.com
\.weatheronline\.pl
^webinsider\.pl
^wolna-polska\.pl
\.wp\.pl
^wsensie\.pl
www\.tvn24\.pl
^zmianynaziemi\.pl
#Russian
.gazeta\.ru
Running command
adblock2privoxy -p /tmp/privoxy -w /tmp/privoxy -d 127.0.0.1:8445 -t privoxy_ab2b.task \ https://easylist-downloads.adblockplus.org/easylist.txt
even with only one source creates among othersab2p.system.action
file. That file includes:This results in privoxy crash if config files created got overridden on running app or fails to start if it was not previously running
Removing leading
*
from those two rules makes privoxy work againSeems that particular record is not related to any adblock.txt list used, but is created by adblock2privoxy itself.