essandess / easylist-pac-privoxy

EasyList Tracker and Adblocks to Proxy Auto Configuration (PAC) File and Privoxy Actions and Filters
GNU General Public License v3.0
103 stars 97 forks source link

Use uOriginBlock unbreak.txt #4

Closed jayvdb closed 5 years ago

jayvdb commented 6 years ago

https://github.com/uBlockOrigin/uAssets/blob/master/filters/unbreak.txt contains extra rules which unbreak easylist rules.

jayvdb commented 6 years ago

This can be achieved with https://github.com/essandess/easylist-pac-privoxy/issues/5 + https://github.com/scrapinghub/adblockparser/issues/13 , and https://github.com/essandess/adblock2privoxy/issues/5

essandess commented 6 years ago

Applying unbreak.txt rules will not necessarily work to fix easyprivacy.txt rules because the existing code presumes that all rules are valid, prioritizes the most relevant ones, then represents these rules in JavaScript hashes or RegExp objects whose execution order is not predefined.

One way to address this is to parse unbreak.txt first and not include any breaks rules subsequently.

Another way—my preference—is just to upstream this issue and ask easyprivacy.txt to fix their rules.